-
-
Notifications
You must be signed in to change notification settings - Fork 571
[6.x] Misc dynamic form builder preparations #10976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
form:fields
tag with support for group fieldtype
form:fields
tag with support for group fieldtypeform:fields
tag with support for group fieldtype
form:fields
tag with support for group fieldtype… the slot recursively 🎉
Update: It passes this morning 😁 ...Unrelated to this PR obviously though. |
…d fields (anyone want a crazy edge case?)
…uns `addContext()`.
…ere its actually used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initially started out as an attempt to add
group
field support, but has grown to include a whole bunch of improvements, with the purpose of improving dynamic field rendering for users, and to prepare for our upcoming GUI based form builder stuff.TODO:
handle
andname
intofields
contextnested[field][format]
input namesnested.field.format
handles forshowField()
JS driver logicgroup
fieldgroup
fieldtype available to frontend formsgroup.antlers.html
fieldtype templatename[format]
instead ofhandle.format
preProcessTagRenderable()
to fieldtypespreProcessTagRenderable()
for group-specific recursion logicshow_fields
array still works at top level for hardcoded fields outside offields
loopshow_field['nested.dotted.handle']
)old
value bug when submitting partial nested field payloads{{ form:fields }}
recursive tag helper{{ form:fields }}
works recursively using{{ fields }}
array context at every level{{ form:fields }}
works recursively within{{ sections }}
loop as wellscope
param (ie.{{ form:fields scope="field" }}
)$parent
conditions syntax, since we assume feature parity with CPparent
keyword to field conditions #9385null
values on things like checkboxes, radios, selects, button groups, etc. in the CP GUI was technically dropped in 4.56.0. This PR removes some extra/related backend handling, so if you still have this in your yaml, it could be breaking for some people in v6.id
renderingform:fields
changes docs#1606Closes statamic/ideas#1228